Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert rsmSpec roles #6799

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: convert rsmSpec roles #6799

merged 1 commit into from
Mar 12, 2024

Conversation

shanshanying
Copy link
Contributor

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Mar 12, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.65%. Comparing base (83a41ad) to head (ccb1f21).

Files Patch % Lines
...roller/component/component_definition_convertor.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6799      +/-   ##
==========================================
- Coverage   65.68%   65.65%   -0.04%     
==========================================
  Files         311      311              
  Lines       37602    37608       +6     
==========================================
- Hits        24699    24691       -8     
- Misses      10802    10816      +14     
  Partials     2101     2101
Flag Coverage Δ
unittests 65.65% <16.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanshanying shanshanying merged commit 1ed4581 into main Mar 12, 2024
115 checks passed
@shanshanying shanshanying deleted the bugfix/convert-rsm-roles branch March 12, 2024 06:26
@shanshanying
Copy link
Contributor Author

/cherry-pick release 0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 12, 2024
@github-actions GitHub Actions
Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8244530358

@JashBook
Copy link
Collaborator

/cherry-pick release-0.8

@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8244554139

github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
@shanshanying @JashBook
fix: convert rsmSpec roles (#6799)
dc0e5af 
Co-authored-by: wusai80 <wusai80@gmail.com>
(cherry picked from commit 1ed4581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuriwuyun xuriwuyun xuriwuyun approved these changes

@Y-Rookie Y-Rookie Y-Rookie approved these changes

@wangyelei wangyelei wangyelei approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om free6om is a code owner

Assignees
No one assigned
Labels
enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.8.2
Development

Successfully merging this pull request may close these issues.

[BUG] mogdb cluster service no selector kubeblocks.io/role: Primary
7 participants
@shanshanying @JashBook @xuriwuyun @Y-Rookie @wangyelei @apecloud-bot @wusai80