Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports to run opsRequest forcibly and queuing based on opsRequest type #6828

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

wangyelei
Copy link
Contributor

@wangyelei wangyelei commented Mar 18, 2024

This PR supports a new flag force for opsRequest.
When running opsRequest, specifying force as true will skip any pre checks, including opsDefinition pre conditions, and run directly except for Start type.
This can increase the concurrency of opsRequest.

If multiple VerticalScaling or HorizontalScaling are executed simultaneously, the latest OpsRequest will prevail.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Mar 18, 2024
@wangyelei wangyelei linked an issue Mar 18, 2024 that may be closed by this pull request
@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 69.57831% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 65.58%. Comparing base (bf5b01b) to head (df7d199).
Report is 5 commits behind head on main.

Files Patch % Lines
controllers/apps/operations/ops_util.go 62.10% 31 Missing and 5 partials ⚠️
controllers/apps/operations/queue_util.go 63.54% 24 Missing and 11 partials ⚠️
controllers/apps/opsrequest_controller.go 82.60% 7 Missing and 1 partial ⚠️
controllers/apps/operations/vertical_scaling.go 82.85% 4 Missing and 2 partials ⚠️
controllers/apps/operations/start.go 63.63% 3 Missing and 1 partial ⚠️
apis/apps/v1alpha1/opsrequest_webhook.go 50.00% 2 Missing and 1 partial ⚠️
controllers/apps/operations/custom.go 50.00% 2 Missing and 1 partial ⚠️
controllers/apps/operations/horizontal_scaling.go 70.00% 2 Missing and 1 partial ⚠️
controllers/apps/operations/stop.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6828      +/-   ##
==========================================
- Coverage   65.72%   65.58%   -0.14%     
==========================================
  Files         310      311       +1     
  Lines       37640    37835     +195     
==========================================
+ Hits        24738    24814      +76     
- Misses      10806    10903      +97     
- Partials     2096     2118      +22     
Flag Coverage Δ
unittests 65.58% <69.57%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit f91a76c into main Mar 18, 2024
47 checks passed
@wangyelei wangyelei deleted the feature/force_run_ops branch March 18, 2024 03:04
@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test ci feature size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] more granular concurrency control for ops request
4 participants