Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose role from rsmSpec #6831

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: expose role from rsmSpec #6831

merged 1 commit into from
Mar 18, 2024

Conversation

shanshanying
Copy link
Contributor

@shanshanying shanshanying commented Mar 18, 2024 •
edited
Loading

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 18, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.66%. Comparing base (83a41ad) to head (2d3a029).
Report is 14 commits behind head on main.

Files Patch % Lines
controllers/apps/operations/expose.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6831      +/-   ##
==========================================
- Coverage   65.68%   65.66%   -0.03%     
==========================================
  Files         311      311              
  Lines       37602    37614      +12     
==========================================
  Hits        24699    24699              
- Misses      10802    10806       +4     
- Partials     2101     2109       +8
Flag Coverage Δ
unittests 65.66% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanshanying
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 18, 2024
@shanshanying shanshanying merged commit 12ab7bc into main Mar 18, 2024
84 of 85 checks passed
@shanshanying shanshanying deleted the bugfix/expose-rsmspec-roles branch March 18, 2024 05:52
@shanshanying
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 18, 2024
@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8321925069

github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
@shanshanying
fix: expose role from rsmSpec (#6831)
2591d53 
Co-authored-by: wusai80 <wusai80@gmail.com>
(cherry picked from commit 12ab7bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

Assignees
No one assigned
Labels
approved PR Approved Test enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 0.8.2
Development

Successfully merging this pull request may close these issues.

[BUG] mogdb expose ops has no ROLE lables
4 participants
@shanshanying @wangyelei @apecloud-bot @wusai80