Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: role probe custom handler for script without bash #6836

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.03%. Comparing base (12ab7bc) to head (afdc0c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6836      +/-   ##
==========================================
- Coverage   66.03%   66.03%   -0.01%     
==========================================
  Files         314      314              
  Lines       38546    38559      +13     
==========================================
+ Hits        25455    25461       +6     
- Misses      10946    10951       +5     
- Partials     2145     2147       +2     
Flag Coverage Δ
unittests 66.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuriwuyun
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 18, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 18, 2024
@xuriwuyun xuriwuyun merged commit 1ccec16 into main Mar 18, 2024
47 checks passed
@xuriwuyun xuriwuyun deleted the bugfix/roleprobe_custom_handler branch March 18, 2024 09:05
@xuriwuyun
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.2 milestone Mar 18, 2024
Copy link

🤖 says: Error cherry-picking.

Auto-merging controllers/apps/component_utils.go
Auto-merging controllers/apps/transformer_component_workload.go
CONFLICT (modify/delete): pkg/lorry/engines/custom/get_replica_role.go deleted in HEAD and modified in 1ccec16 (fix: role probe custom handler for script without bash (#6836)). Version 1ccec16 (fix: role probe custom handler for script without bash (#6836)) of pkg/lorry/engines/custom/get_replica_role.go left in tree.
error: could not apply 1ccec16... fix: role probe custom handler for script without bash (#6836)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8323896007

@xuriwuyun
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8324183227

github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
4 participants