Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cluster is always in 'DeleteCR' after deleted #6890

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Mar 26, 2024

fixed #6886

@free6om free6om added this to the Release 0.9.0 milestone Mar 26, 2024
@free6om free6om self-assigned this Mar 26, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.79%. Comparing base (aa96c9b) to head (090af34).

Files Patch % Lines
...ers/workloads/replicatedstatemachine_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6890      +/-   ##
==========================================
- Coverage   65.86%   65.79%   -0.08%     
==========================================
  Files         332      332              
  Lines       40764    40766       +2     
==========================================
- Hits        26850    26822      -28     
- Misses      11583    11613      +30     
  Partials     2331     2331              
Flag Coverage Δ
unittests 65.79% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit 09688a9 into main Mar 26, 2024
85 checks passed
@free6om free6om deleted the bugfix/cluster-is-always-DeleteCR branch March 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]cluster is always DeletingCR for Operation cannot be fulfilled
4 participants