Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused annotations and clean code #7047

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

Y-Rookie
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.75%. Comparing base (6376b2f) to head (168b424).

Files Patch % Lines
...trollers/apps/transformer_component_hostnetwork.go 0.00% 3 Missing ⚠️
controllers/apps/operations/rebuild_instance.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7047      +/-   ##
==========================================
+ Coverage   65.67%   65.75%   +0.07%     
==========================================
  Files         337      337              
  Lines       41700    41698       -2     
==========================================
+ Hits        27387    27417      +30     
+ Misses      11939    11912      -27     
+ Partials     2374     2369       -5     
Flag Coverage Δ
unittests 65.75% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie
Copy link
Collaborator Author

/approve

@Y-Rookie Y-Rookie merged commit 3ce3b2b into main Apr 15, 2024
83 checks passed
@Y-Rookie Y-Rookie deleted the support/remove-unused-annotation-and-clean-code branch April 15, 2024 09:15
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 15, 2024
@Y-Rookie
Copy link
Collaborator Author

/cherry-pick release-0.9

Copy link

🤖 says: Error cherry-picking.

Auto-merging pkg/constant/const.go
CONFLICT (content): Merge conflict in pkg/constant/const.go
error: could not apply 3ce3b2b... chore: remove unused annotations and clean code (#7047)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8686580247

Y-Rookie added a commit that referenced this pull request Apr 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants