Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: say goodbye to the RSM and hello to the InstanceSet #7084

Merged
merged 17 commits into from
Apr 18, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Apr 18, 2024

No description provided.

@free6om free6om added this to the Release 0.9.0 milestone Apr 18, 2024
@free6om free6om self-assigned this Apr 18, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 18, 2024
@free6om free6om marked this pull request as draft April 18, 2024 11:28
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 71.70172% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 65.62%. Comparing base (f1c6df1) to head (b57e7b5).

Files Patch % Lines
pkg/controller/component/rsm_convertor.go 12.50% 49 Missing ⚠️
controllers/apps/transformer_component_workload.go 79.46% 13 Missing and 10 partials ⚠️
controllers/workloads/instanceset_controller.go 37.50% 14 Missing and 1 partial ⚠️
controllers/apps/transformer_component_status.go 74.19% 0 Missing and 8 partials ⚠️
pkg/controller/component/pod_utils.go 0.00% 8 Missing ⚠️
pkg/controller/instanceset/reconciler_update.go 71.42% 4 Missing and 2 partials ⚠️
apis/workloads/v1alpha1/instanceset_webhook.go 63.63% 4 Missing ⚠️
pkg/controller/component/vars.go 0.00% 4 Missing ⚠️
pkg/controller/component/workload_utils.go 0.00% 4 Missing ⚠️
...oller/instanceset/reconciler_instance_alignment.go 60.00% 3 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7084      +/-   ##
==========================================
- Coverage   65.69%   65.62%   -0.08%     
==========================================
  Files         341      341              
  Lines       42003    42003              
==========================================
- Hits        27594    27563      -31     
- Misses      12035    12057      +22     
- Partials     2374     2383       +9     
Flag Coverage Δ
unittests 65.62% <71.70%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om marked this pull request as ready for review April 18, 2024 16:26
@free6om free6om merged commit 5163a18 into main Apr 18, 2024
81 checks passed
@free6om free6om deleted the support/rename-rsm-to-instanceset branch April 18, 2024 16:27
@free6om
Copy link
Contributor Author

free6om commented Apr 18, 2024

/cherry-pick release-0.9

Copy link

🤖 says: Error cherry-picking.

Auto-merging PROJECT
Auto-merging cmd/manager/main.go
Auto-merging config/crd/bases/apps.kubeblocks.io_clusters.yaml
Auto-merging config/crd/kustomization.yaml
CONFLICT (content): Merge conflict in config/crd/kustomization.yaml
Auto-merging config/rbac/role.yaml
Auto-merging controllers/apps/component_controller.go
Auto-merging controllers/apps/component_controller_test.go
Auto-merging controllers/apps/opsrequest_controller_test.go
CONFLICT (content): Merge conflict in controllers/apps/opsrequest_controller_test.go
Auto-merging deploy/helm/config/rbac/role.yaml
Auto-merging deploy/helm/crds/apps.kubeblocks.io_clusters.yaml
Auto-merging docs/developer_docs/api-reference/cluster.md
Auto-merging pkg/client/informers/externalversions/generic.go
Auto-merging pkg/constant/const.go
Auto-merging pkg/controller/instanceset/revision_util_test.go
Auto-merging pkg/generics/type.go
error: could not apply 5163a18... chore: say goodbye to the RSM and hello to the InstanceSet (#7084)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8741466171

@free6om free6om changed the title chore: say goodby to the RSM and hello to the InstanceSet chore: say goodbye to the RSM and hello to the InstanceSet Apr 18, 2024
free6om added a commit that referenced this pull request Apr 18, 2024
free6om added a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants