Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support load balancer service in multi-cluster #7133

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 23, 2024
@leon-inf leon-inf marked this pull request as ready for review April 23, 2024 09:15
@leon-inf leon-inf force-pushed the support/lb-service-in-multi-cluster branch from 18973d9 to 15caa5f Compare April 23, 2024 09:34
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 78.67647% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 64.82%. Comparing base (7cba146) to head (5be6147).
Report is 7 commits behind head on main.

Files Patch % Lines
controllers/apps/transformer_component_service.go 31.25% 17 Missing and 5 partials ⚠️
controllers/apps/systemaccount_controller.go 33.33% 4 Missing and 2 partials ⚠️
pkg/controller/component/vars.go 98.94% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7133      +/-   ##
==========================================
+ Coverage   64.78%   64.82%   +0.03%     
==========================================
  Files         337      337              
  Lines       41518    41606      +88     
==========================================
+ Hits        26899    26972      +73     
- Misses      12278    12282       +4     
- Partials     2341     2352      +11     
Flag Coverage Δ
unittests 64.82% <78.67%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the support/lb-service-in-multi-cluster branch from 15caa5f to dbc5ca4 Compare April 24, 2024 02:52
@leon-inf leon-inf force-pushed the support/lb-service-in-multi-cluster branch 3 times, most recently from e0db691 to 1eaa5b8 Compare April 24, 2024 06:37
@leon-inf leon-inf force-pushed the support/lb-service-in-multi-cluster branch from 1eaa5b8 to 5cfa493 Compare April 24, 2024 06:43
@apecloud-bot apecloud-bot added the approved PR Approved Test label Apr 24, 2024
@leon-inf
Copy link
Contributor Author

/approve

@leon-inf leon-inf merged commit d22abd5 into main Apr 25, 2024
51 checks passed
@leon-inf leon-inf deleted the support/lb-service-in-multi-cluster branch April 25, 2024 00:43
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 25, 2024
@leon-inf
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8825238252

github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants