feat: support to reference other components vars #7155
Conversation
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om and
wangyelei
as code owners
Y-Rookie
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7155 +/- ##
==========================================
+ Coverage 64.77% 64.81% +0.03%
==========================================
Files 338 338
Lines 41842 41883 +41
==========================================
+ Hits 27104 27147 +43
- Misses 12372 12373 +1
+ Partials 2366 2363 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apis/apps/v1alpha1/type.go
Outdated
| // and the value will be presented in the following format: podName1,podName2... | ||
| // | ||
| // +optional | ||
| PodNames *VarOption `json:"podNames,omitempty"` |
There was a problem hiding this comment.
consider calling it InstanceNames ? as Instance has been defined as the fundmental unit of KB from the 4-layer model.
There was a problem hiding this comment.
consider calling it
InstanceNames? as Instance has been defined as the fundmental unit of KB from the 4-layer model.
fixed
|
/approve |
Y-Rookie
deleted the
support/support-reference-another-component-podlist
branch
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
(cherry picked from commit aa9497f)
No description provided.