Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lifecycle action done annotation validation #7521

Merged

Conversation

Y-Rookie
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jun 13, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (b89eae4) to head (72c724e).

Files Patch % Lines
pkg/controller/component/action_utils.go 30.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7521      +/-   ##
==========================================
+ Coverage   65.92%   66.01%   +0.09%     
==========================================
  Files         343      343              
  Lines       42175    42174       -1     
==========================================
+ Hits        27805    27843      +38     
+ Misses      11935    11901      -34     
+ Partials     2435     2430       -5     
Flag Coverage Δ
unittests 66.01% <30.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie Y-Rookie merged commit e1a7513 into main Jun 13, 2024
56 checks passed
@Y-Rookie Y-Rookie deleted the support/fix-lifecycle-action-done-annotation-validation branch June 13, 2024 05:01
@github-actions github-actions bot added this to the Release 0.8.4 milestone Jun 13, 2024
@Y-Rookie
Copy link
Collaborator Author

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/9493981563

github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants