Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PodManagementPolicy for the instanceSet controller #7540

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sophon-zt
Copy link
Contributor

  1. KingbaseES depends on this OrderedReady strategy

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 14, 2024
@sophon-zt sophon-zt linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (3f405b3) to head (7835c0b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7540      +/-   ##
==========================================
+ Coverage   66.03%   66.09%   +0.06%     
==========================================
  Files         343      343              
  Lines       42186    42194       +8     
==========================================
+ Hits        27856    27888      +32     
+ Misses      11902    11879      -23     
+ Partials     2428     2427       -1     
Flag Coverage Δ
unittests 66.09% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 16, 2024
@sophon-zt sophon-zt merged commit 3c6237e into main Jun 18, 2024
59 checks passed
@sophon-zt sophon-zt deleted the feature/support-component-pod-management-policy branch June 18, 2024 03:06
@github-actions github-actions bot added this to the Release 0.8.4 milestone Jun 18, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

🤖 says: Error cherry-picking.

Auto-merging apis/apps/v1alpha1/componentdefinition_types.go
Auto-merging apis/apps/v1alpha1/zz_generated.deepcopy.go
Auto-merging config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging deploy/helm/crds/apps.kubeblocks.io_componentdefinitions.yaml
Auto-merging docs/developer_docs/api-reference/cluster.md
Auto-merging pkg/controller/component/synthesize_component.go
CONFLICT (content): Merge conflict in pkg/controller/component/synthesize_component.go
error: could not apply 3c6237e... feat: support PodManagementPolicy for the instanceSet controller (#7540)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/9558308744

sophon-zt added a commit that referenced this pull request Jun 18, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] KingbaseES depends on this OrderedReady strategy
4 participants