Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove description and custom labels from cd #7769

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.77%. Comparing base (8bacb40) to head (a843d32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7769      +/-   ##
==========================================
+ Coverage   64.75%   64.77%   +0.01%     
==========================================
  Files         345      345              
  Lines       43056    43033      -23     
==========================================
- Hits        27880    27873       -7     
+ Misses      12716    12701      -15     
+ Partials     2460     2459       -1     
Flag Coverage Δ
unittests 64.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// +listType=map
// +listMapKey=key
// +optional
CustomLabelSpecs []CustomLabelSpec `json:"customLabelSpecs,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the structure of CustomLabelSpec also be removed synchronously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@leon-inf leon-inf force-pushed the support/remove-description-labels-from-cd branch from eafd05c to 518b3c2 Compare July 11, 2024 03:35
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 11, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jul 26, 2024
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 26, 2024
@leon-inf leon-inf merged commit 82e2f54 into main Jul 26, 2024
54 checks passed
@leon-inf leon-inf deleted the support/remove-description-labels-from-cd branch July 26, 2024 07:27
@github-actions github-actions bot added this to the 0.9.2 milestone Jul 26, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants