-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TemplatesStatus field to InstanceSetStatus #7781
Conversation
Signed-off-by: Liang Deng <283304489@qq.com>
96b5275
to
08315d6
Compare
@weicao @free6om Two more points might need to be discussed:
|
The Component is also an internal object. I think it's all right to observe&watch the status of internal objects. So it's fine to put
Will the InstanceSet CR exceed maximum size in kuaishou's environment if |
I would treat the main target of this PR as to resolve the Karmada Interpreter related issue, and prefer to keep the top Cluster&Component APIs as simple as possible.
Base on one test we did before, 200 items of TemplatesStatus is a safe bar against object size, you can do an evaluation of your use scenario. |
Sure
We have at most a few dozen templates in our scenario, so this is completely sufficient. @free6om So, it looks like we can merge this PR now? |
/cherry-pick release-0.9 |
🤖 says: cherry pick action finished successfully 🎉! |
Signed-off-by: Liang Deng <283304489@qq.com> (cherry picked from commit 9daafb7)
resolve #7400