Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cmpd immutable check as default #7806

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Jul 15, 2024

fixed #6755

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.73%. Comparing base (844c8b6) to head (049eb72).
Report is 2 commits behind head on main.

Files Patch % Lines
controllers/apps/componentdefinition_controller.go 83.33% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7806      +/-   ##
==========================================
- Coverage   64.81%   64.73%   -0.09%     
==========================================
  Files         345      345              
  Lines       42832    42902      +70     
==========================================
+ Hits        27760    27771      +11     
- Misses      12631    12679      +48     
- Partials     2441     2452      +11     
Flag Coverage Δ
unittests 64.73% <83.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 15, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jul 15, 2024
@leon-inf leon-inf changed the title feat: cmpd immutable validation feat: cmpd immutable check as default Jul 15, 2024
@leon-inf leon-inf merged commit 29ec1d7 into main Jul 16, 2024
69 of 70 checks passed
@leon-inf leon-inf deleted the feature/cmpd-immutable branch July 16, 2024 05:30
@leon-inf
Copy link
Contributor Author

/cherry-pick release-0.9

@github-actions github-actions bot added this to the Release 0.8.4 milestone Jul 16, 2024
Copy link

🤖 says: Error cherry-picking.

Auto-merging controllers/apps/component_controller_test.go
Auto-merging pkg/constant/annotations.go
CONFLICT (content): Merge conflict in pkg/constant/annotations.go
Auto-merging pkg/testutil/apps/componentdefinition_factory.go
error: could not apply 29ec1d7... feat: cmpd immutable check as default (#7806)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/9951298690

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test area/user-interaction size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
4 participants