-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused application addons #7866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldming
requested review from
nayutah,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
July 23, 2024 13:07
weicao
approved these changes
Jul 23, 2024
@JashBook FYI, the minio addon will be gone, CI scripts should be updated accordingly. |
zjx20
approved these changes
Jul 23, 2024
github-actions
bot
added
size/XL
Denotes a PR that changes 500-999 lines.
and removed
size/L
Denotes a PR that changes 100-499 lines.
labels
Jul 23, 2024
weicao
approved these changes
Jul 23, 2024
/cherry-pick release-0.9 |
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit abd942d)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused application addons.
The addon specified in deploy/helm/templates/applications/minio.yaml shares the same name as the addon located at https://github.com/apecloud/kubeblocks-addons/tree/main/addons/minio. Consequently, executing the command “kbcli addon enable minio” will install the former, which is not the desired outcome.