Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused application addons #7866

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Jul 23, 2024

Remove unused application addons.

The addon specified in deploy/helm/templates/applications/minio.yaml shares the same name as the addon located at https://github.com/apecloud/kubeblocks-addons/tree/main/addons/minio. Consequently, executing the command “kbcli addon enable minio” will install the former, which is not the desired outcome.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jul 23, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 23, 2024
@zjx20
Copy link
Contributor

zjx20 commented Jul 23, 2024

@JashBook FYI, the minio addon will be gone, CI scripts should be updated accordingly.

@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jul 23, 2024
@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jul 23, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 23, 2024
@ldming ldming merged commit abd942d into main Jul 24, 2024
29 checks passed
@ldming ldming deleted the support/remove-unused-app-addons branch July 24, 2024 00:51
@github-actions github-actions bot added this to the Release 0.8.4 milestone Jul 24, 2024
@ldming
Copy link
Collaborator Author

ldming commented Jul 24, 2024

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/10068586598

github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants