-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will phpCAS work with php 7.1? #224
Comments
I guess this is something that we can fix. The only reason we this strange mapping of CAS Ticket to session ID is that we need to have a mapping between CAS Ticket ID and PHP session to allow for a single lockout without having and database.. My idea to fix this would be use sha256("ST-YXXXX" + random_seed) to generate the session ID in the future. This would however require everyone to configure their own seed once during setup. We could also just use the domain/host as additional seed value. @adamfranco: Any thoughts on this? |
Yes, this breaks on php 7.1 |
I'm working on a patch |
Is there a timeframe for a release that works on PHP 7.1? |
Any update on this? This seems to be generating a lot of similar issues, so it seems pretty desirable. |
Is there a need for the random seed? |
…n-ids. By using a sha256 hash of the ticket, the session-id is guarenteed to be 64 bytes long no matter how short or long the ticket provided by the CAS server is. This fixes #248, fixes #244, and partially addresses the comments in #224 with the exception of an extra salt or random-seed when generating the hash.
I recently was looking into issue dokuwiki/dokuwiki#1904 with CAS-authentication in dokuwiki using the authplaincas extension, which uses phpCAS. phpCAS replaces the session ID by a 13-character string, and dokuwiki doesn't like session ID's smaller than 22 characters.
In the discussion on the issue, @mprins pointed out that in php 7.1 session ID's should have a length of at least 22. So I guess php 7.1 might break phpCAS. I didn't try it out though.
See also esn-org/authplaincas#9.
The text was updated successfully, but these errors were encountered: