fix: failed blind state check/no battery now logs and does not crash, f…

…ixes #56
apexad · Apr 5, 2021 · 7b5ba35 · 7b5ba35
1 parent f8e3c5d
commit 7b5ba35
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -16,6 +16,7 @@
   },
   "dependencies": {
     "jsonwebtoken": "^8.5.1",
+    "lodash": "^4.17.21",
     "prompt": "^1.0.0",
     "request": "^2.88.2",
     "request-promise": "^4.2.6"

diff --git a/src/platform.ts b/src/platform.ts
@@ -9,6 +9,9 @@ import {
   Service,
   Characteristic,
 } from 'homebridge';
+import {
+  get,
+} from 'lodash';
 import {
   PLATFORM_NAME,
   PLUGIN_NAME,
@@ -158,7 +161,12 @@ export class MySmartBlindsBridgePlatform implements DynamicPlatformPlugin {
                 this.requestOptions,
                 { body: { query: MYSMARTBLINDS_QUERIES.GetBlindSate, variables: { blinds: blind.encodedMacAddress } } },
               )).then((response) => {
-                const blindState = response.data.blindsState[0];
+                const blindState = get(response, 'data.blindsState[0]', { position: 0, batteryLevel: 0 });
+
+                if (blindState.batteryLevel <= 0) {
+                  this.log.error(`${blindName} state fetch failed.  Do you have the Hardware bridge? Is the battery charged?`);
+                }
+
                 const homeKitBlindPosition = this.convertPosition(blindState.position);
                 accessory.context.blind = {
                   name: blindName,