-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added condition to hide donut total label if hideLabel flag is set per issue #4370 #4516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dramaga11
approved these changes
Jul 5, 2024
Dramaga11
approved these changes
Jul 5, 2024
Sorry for the delay here @halfpeeled |
Sure, that makes sense to me. |
junedchhipa
added a commit
that referenced
this pull request
Sep 18, 2024
I have fixed the original issue in this commit based on your logic. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
Summary of changes:
Added a condition to Pie.js so that donut chart total labels can display the total number without the label if desired. This is set by the flag hideLabel which can be passed as an option to the plotOptions.pie.donut.labels.total. This was motivated by this issue requesting the feature. I was not sure how to go about adding an additional test for this small change, but all existing tests still passed.
Fixes # 4370
Type of change
Checklist: