-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Export numberFormatter #4538
Conversation
I thought these lines are only for categories. But you are right they can be numbers too. |
I think that should be it. Any chance to integrate the changes? |
@ggrote I am thinking of merging datetimeFormatter and numberFormatter together and provide a generic formatter. It is going to be a breaking change, so I am still thinking about it. |
Okay, how do you want to know which value should be formatted? By type? |
instead of dateFormatter and numberFormatter, I have used the correct namings.
Docs will be updated after the new release |
New Pull Request
We needed the numbers in a csv export to be formatted correctly with a comma as a decimal separator. So I thought it would be a good way to implement a numberFormatter like the dateFormatter for the CSV Export.
Type of change
Please delete options that are not relevant.
Checklist:
Sorry, I don't know how to write unit tests.