-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated rollup-plugin-terser
with @rollup/plugin-terser
#4547
Merged
junedchhipa
merged 1 commit into
apexcharts:main
from
poteboy:chore/update-terser-plugin
Jul 1, 2024
Merged
Replace deprecated rollup-plugin-terser
with @rollup/plugin-terser
#4547
junedchhipa
merged 1 commit into
apexcharts:main
from
poteboy:chore/update-terser-plugin
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
approved these changes
Jul 1, 2024
This was referenced Jul 28, 2024
This was referenced Aug 1, 2024
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
The
rollup-plugin-terser
has not had a commit in four years, has been deprecated, and is no longer maintained. Therefore, I have replaced it with its successor,@rollup/plugin-terser
.Additionally, I noticed that the
makeMap
function, which was passed to thepure_funcs
option, is not defined anywhere in the codebase (as verified by a grep search). Including such a function that is undefined and potentially has side effects in the future is error-prone. Hence, I have removed this option.Other PRs (such as apexcharts#3709) have updated dependencies without performing a build. Following this precedent, this PR does not include an updated build.
Type of change
Please delete options that are not relevant.
Checklist: