Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to accommodate issue 4632 #4640

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Aug 15, 2024

  1. Unconditionally select default initial axis ticks based on SVG size.
  2. Unconditionally, if not user specified, snap yMin or yMax to zero if already close.
  3. Re-order yaxes in one sample chart to prioritize stacked column visual resolution. Add comment to draw attention to this feature of multi axis charts.
  4. In Scales.niceScale: Check that maxTicks is always valid (suspect some Unit tests don't set SVG dimensions).
  5. Set tickAmount explicitly in two unit tests to compensate for variation in scaling following the above changes.

Fixes #4632

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@rosco54
Copy link
Contributor Author

rosco54 commented Aug 15, 2024

@junedchhipa There are e2e images diff failures that cause the automated checks below to fail. Most are expected but some that I don't expect (like the heatmap diffs). I assume you will be looking at these before accepting the PR. Let me know if there's anything that I need to do at this end please.

@rosco54 rosco54 marked this pull request as ready for review August 15, 2024 10:01
1. Unconditionally select default initial axis ticks based on SVG size.
2. Unconditionally, if not user specified, snap yMin or yMax to zero
if already close.
3. Re-order yaxes in one sample chart to prioritize stacked column
visual resolution. Add comment to draw attention to this feature of
multi axis charts.
4. In Scales.niceScale: Check that maxTicks is always valid (suspect
some Unit tests don't set SVG dimensions).
5. Set tickAmount explicitly in two unit tests to compensate for
variation in scaling following the above changes.
@junedchhipa junedchhipa merged commit c69f253 into apexcharts:main Aug 15, 2024
4 of 7 checks passed
@rosco54 rosco54 deleted the Issue_4632 branch August 16, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent/buggy yaxis ticks (too many or none)
2 participants