Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar and column true stroke and fill paths #4753

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Oct 10, 2024

This is a request to consider restoring a visual feature that was removed from the repository main branch (the change has not yet been released).

The feature was removed as part of recent improvements to corner radius rendering but the change did not reference any issue number or provide a rationale in the commit for this specific change, which does not appear to affect corner radii AFAIKS.

The feature is best illustrated:

Without the feature

  1. At least one existing sample chart doesn't render as expected. Example: a column chart that defines a stroke width of 2 and transparent color expecting to show a gap between columns. No gap appears because fills abutt.
    fc3noor2 (2)

  2. Stacked column chart with stroke outlines that:
    . overlap
    . require the viewer to visually disambiguate
    . looks untidy
    fc3noor2 (1)

With the feature

  1. The gap is now visible.
    fc3noor2 (3)

  2. Stacked column chart that looks clean and visually unambiguous.
    fc3noor2

Improvements

Works as expected for stacked bars/columns with negative values

fc3noor2 (2)

Works as expected for reversed axis charts

fc3noor2 (3)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@rosco54 rosco54 force-pushed the Bar_Column_True_Stroke_Path branch from 0025341 to 596bcd3 Compare October 11, 2024 01:39
Strokes on different bars/columns should not overlap or cause
bar/columns to appear longer or wider than their values dictate or
be visually ambiguous.

Include fix paths for negative and reversed bar/column rendering that
required removal of this feature.

border-radius-test: change breakpoint for better aesthetics at narrow
chart width.

stacked-column-outline.xml: New sample source
stacked-column-outline.* : Products of new sample
@rosco54 rosco54 force-pushed the Bar_Column_True_Stroke_Path branch from 596bcd3 to fedbcce Compare October 11, 2024 03:00
@rosco54 rosco54 marked this pull request as ready for review October 11, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants