Update types to add missing arguments and return types #4772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing types
1️⃣
The
dataLabels
formatter can return an array. It will display both strings on a separate line.You can see this usage in this demo: Treemap color range
We can see further down in the code that the function is handling the case where
text
is an array:apexcharts.js/src/modules/Graphics.js
Line 693 in 483c471
2️⃣
The tooltip y formatter, accepts a second argument (like many other formatters), it's
opts?: any
and is missing.This one fixes #4762
Type of change
Please delete options that are not relevant.
Checklist: