Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks loop when iterating over empty series and restores #4782 #4871

Merged

Conversation

bautisflow
Copy link
Contributor

@bautisflow bautisflow commented Dec 14, 2024

As discussed in #4782 a break has been implemented when iterating over the an empty series, where the iteration range is the maximum dataPoints range of the series in the chart.

It also fixes #4855 while keeping the fix in #4782

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@junedchhipa junedchhipa merged commit 53881ec into apexcharts:main Dec 17, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area chart series toggling issue introduced in 4.1.0
2 participants