Add support for icons #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icon support is only implemented for macos at this point Icon rendering must use platform-specific APIs which means it must be duplicated for every supported OS. Icon lookup is delegated to a separate thread in order to prevent the system functions from blocking the runtime. This is because if a Jolly entry location is on a network drive, the icon lookup APIs can hang for a long period of time.
Support for SVG based icon themes Check multiple mimetypes before choosing icon for image Icon size can be adjusted Buildscript checks that necessary packages are installed and gives a warning if they are not
Still not perfect, no tests and lots of corner cases not covered.
Still not perfect, no tests and lots of corner cases not covered.
Windows CI runner on github does not have a default mailo handler. This caused CI to file. Also, test was updated to check all urls and summarize failures at the end, so the next time CI runs we can see all failing URLs, not the first one to fail.
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons are now supported on Windows, macOS, and Freedesktop based platforms.
Fixes #18