Adjust null handling in exported JSON Schema / OpenAPI #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
changed the title
Korbeil
force-pushed
the
feature/add-nullable-to-property
branch
5 times, most recently
from
ba308b4 to
2fc14d6
Compare
Korbeil
changed the title
Korbeil
force-pushed
the
feature/add-nullable-to-property
branch
from
2fc14d6 to
bf4b2b0
Compare
Korbeil
changed the title
Korbeil
changed the title
Korbeil
commented
Apr 23, 2020
| @@ -214,7 +214,7 @@ private function buildPropertySchema(Schema $schema, string $definitionName, str | |||
| $className = $valueType->getClassName(); | |||
| } | |||
|
|
|||
| $valueSchema = $this->typeFactory->getType(new Type($builtinType, $type->isNullable(), $className, $isCollection), $format, $propertyMetadata->isReadableLink(), $serializerContext, $schema); | |||
| $valueSchema = $this->typeFactory->getType(new Type($builtinType, !$propertyMetadata->isRequired() || $type->isNullable(), $className, $isCollection), $format, $propertyMetadata->isReadableLink(), $serializerContext, $schema); | |||
There was a problem hiding this comment.
Being nullable is not enought here, we also need to check if the property is required.
If it's not required, it means this property should be nullable.
Korbeil
changed the title
Korbeil
force-pushed
the
feature/add-nullable-to-property
branch
3 times, most recently
from
82ba090 to
a2cfac2
Compare
Korbeil
changed the title
soyuka
approved these changes
Apr 29, 2020
alanpoulain
force-pushed
the
feature/add-nullable-to-property
branch
from
a2cfac2 to
ede900f
Compare
alanpoulain
force-pushed
the
feature/add-nullable-to-property
branch
from
ede900f to
84e09da
Compare
|
Should it be really the case though? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3402 was a really good start to have a better null handling in exported schema.
But actually we should use required attribute as a condition for nullability.
A non-required property should be nullable.