Support subresource resourceClass resolving #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esserj
changed the title
|
Failed tests seem unrelated? |
|
Hello @esserj, thanks for this PR. It seems weird the Behat tests are failing and may be related to your PR. |
|
@alanpoulain I checked out origin/master and its the same problem, Seems the taxons route has somehow been renamed to taxa causing related tests to fail |
|
and BTW taxa is the plural form of taxon |
|
This issue is done due to the Doctrine/Inflector update v1.4. As mentioned by @esserj it is a fix for this pluralization, so either test should be adjusted or custom rule should be added |
|
It has been fixed on master. Please make a rebase. Also it's a good thing to allow edit from maintainers 🙂 |
esserj
force-pushed
the
fix-resourceClass-not-resolving
branch
from
9e4cdfc to
78c8b0e
Compare
|
Done |
alanpoulain
approved these changes
May 30, 2020
|
Thank you @esserj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow you to define
subresource.resourceClassas a parameter of the container.The extractors have support for resolving class names through container defined parameters, but the subResource class did not have support for this, which kind of makes the use of parameters as a flexibility measure a little less useful when you want to use subResources.