Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate data transformers #4722

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Apr 20, 2022

No description provided.

@soyuka soyuka force-pushed the fix/deprecate-datatransformer branch from 4fcc319 to bffb258 Compare April 21, 2022 12:16
@soyuka soyuka merged commit 39b4e43 into api-platform:main Apr 21, 2022
@norkunas
Copy link
Contributor

And what does it fix? 🙂 Imho doesn't make sense in one major to introduce feature and in another remove it

@tacman
Copy link
Contributor

tacman commented Jun 19, 2022

Fortunately, data transformers still exist, but the pattern is deprecated. According to the deprecation message: "use a Provider or a Processor and either use your input or return a new output there."

@soyuka
Copy link
Member Author

soyuka commented Sep 7, 2022

And what does it fix? slightly_smiling_face Imho doesn't make sense in one major to introduce feature and in another remove it

Most of the cases where people struggle is related to this pattern. It was wrong from the beginning and instead we advise to handle the case in a Processor (see #4892 (comment)).

Input/Output is still available and now every object (anonymous or ApiResource-tagged is considered as an http Resource).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants