feat: deprecate query parameter validator #6454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that we deprecate the QueryParameterValidator in 3.4 in favor of using the new parameter attributes (QueryParameter and HeaderParameter). By doing so, we introduce a backward compatibility flag:
This flag is
true
by default in 3.4 and gets removed in 4.0. When usingfalse
we add parameters for each declared filter and validation will still be effective (according to$queryParameterValidationEnabled
). A few changes occur though (hence the flag):collectionFormat
support from swagger, indeed this completely changed in OpenAPI 3.1 and we did not yet add the support ofstyle
validation on parameters (https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#style-values)Left tbd:
queryParameterValidationEnabled
everywhere (as it also applies to graphqlargs
)use_legacy_parameter_validator
is notfalse