feat(doctrine): add new filter for filtering an entity using PHP backed enum, resolves #6506 #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mremi
force-pushed
the
feat-backed-enum
branch
2 times, most recently
from
61e86ce to
ce4e62c
Compare
mremi
changed the title
mremi
force-pushed
the
feat-backed-enum
branch
3 times, most recently
from
57cd113 to
69bca82
Compare
|
Hi @soyuka , could you please review it? |
soyuka
reviewed
Aug 29, 2024
|
|
||
| // Doctrine ORM 2.x returns an array and Doctrine ORM 3.x returns a FieldMapping object | ||
| if ($fieldMapping instanceof FieldMapping) { | ||
| $fieldMapping = (array) $fieldMapping; |
There was a problem hiding this comment.
does main support ORM 2.x ? I think that we can add the code only for 3.x
There was a problem hiding this comment.
looks like it is https://github.com/api-platform/core/blob/main/composer.json#L68
mremi
force-pushed
the
feat-backed-enum
branch
from
69bca82 to
bcf8306
Compare
|
thanks! |
soyuka
pushed a commit
to soyuka/core
that referenced
this pull request
Aug 30, 2024
|
@soyuka when will be bumped the next release including it? |
|
@mremi during the API Platform Conference! It will be part of API Platform 3.4 and 4.0. |
|
@dunglas nice! Thank you |
|
@mremi can you add a documentation for this? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new Doctrine filter for filtering an entity using PHP backed enum