fix(serializer): allow state's SerializerFilterContextBuilderInterface #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erializerContextBuilderInterface
soyuka
reviewed
Sep 20, 2024
|
Nice catch thanks, added a PR on 4.0 to remove the interface |
soyuka
changed the title
dunglas
approved these changes
Sep 20, 2024
|
Thank you @michalbundyra |
michalbundyra
deleted the
fix/deprecated-serializer-context-builder-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
ApiPlatform\Serializer\SerializerContextBuilderInterfaceis deprecated in favour ofApiPlatform\State\SerializerContextBuilderInterfaceand:it is not possible to use non-deprecated inteface for a ContextBuilder, as the
ApiPlatform\Serializer\SerializerFilterContextBuilderis still expecting deprecated interface for$decoratedparameter.It looks like this deprecated interface has not been removed also in v4, where I should expect it to be gone.
Hope it makes sense.