-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation command, fix config overwrites #6649
Conversation
Note: Some first-party packages, such as Laravel Telescope or Laravel Horizon, provide an artisan command like Let me know if this is something you'd like to incorporate! |
If I understand correctly the configuration won't be copied on package install right? Indeed I think we should introduce such a command and add it in the composer.json scripts so that's there no other step then |
Yes, while the config won't be copied by default, however this is actually expected behavior for Laravel packages. Even first-party packages like Telescope, Horizon, etc., do not automatically publish configs and assets upon installation. You can see this reflected in their installation instructions (Telescope, Horizon, Scout). The Laravel documentation on package development also outlines this as standard practice in the Laravel ecosystem. While I'm not deeply familiar with composer post-install/update scripts, they seem to run every time commands like |
I was thinking that if we create our own Also, I see by using see also https://github.com/laravel/laravel/blob/11.x/composer.json#L32-L47 I really think that we should have the less steps possible to start a new api platform project, and I agree that replacing the configuration file is not good. @dunglas any opinion on this? |
I'll go for the |
I added the install command, also updated the documentation PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added the installation command, but as a bug fix since configs are currently getting overwritten. Closes: api-platform#6645
Thanks!! |
Fix group names for pulishing config and assets.
Closes #6645