fix(laravel): jsonapi query parameters (page, sort, fields and include)

src/JsonApi/Filter/SparseFieldset.php

@@ -0,0 +1,52 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\JsonApi\Filter;
+
+use ApiPlatform\Metadata\JsonSchemaFilterInterface;
+use ApiPlatform\Metadata\OpenApiParameterFilterInterface;
+use ApiPlatform\Metadata\Parameter as MetadataParameter;
+use ApiPlatform\Metadata\ParameterProviderFilterInterface;
+use ApiPlatform\Metadata\PropertiesAwareInterface;
+use ApiPlatform\Metadata\QueryParameter;
+use ApiPlatform\OpenApi\Model\Parameter;
+
+final class SparseFieldset implements OpenApiParameterFilterInterface, JsonSchemaFilterInterface, ParameterProviderFilterInterface, PropertiesAwareInterface
+{
+    public function getSchema(MetadataParameter $parameter): array
+    {
+        return [
+            'type' => 'array',
+            'items' => [
+                'type' => 'string',
+            ],
+        ];
+    }
+
+    public function getOpenApiParameters(MetadataParameter $parameter): Parameter|array|null
+    {
+        return new Parameter(
+            name: ($k = $parameter->getKey()).'[]',
+            in: $parameter instanceof QueryParameter ? 'query' : 'header',
+            description: 'Allows you to reduce the response to contain only the properties you need. If your desired property is nested, you can address it using nested arrays. Example: '.\sprintf(
+                '%1$s[]={propertyName}&%1$s[]={anotherPropertyName}',
+                $k
+            )
+        );
+    }
+
+    public static function getParameterProvider(): string
+    {
+        return SparseFieldsetParameterProvider::class;
+    }
+}

src/JsonApi/Filter/SparseFieldsetParameterProvider.php

@@ -0,0 +1,62 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\JsonApi\Filter;
+
+use ApiPlatform\Metadata\Operation;
+use ApiPlatform\Metadata\Parameter;
+use ApiPlatform\State\ParameterProviderInterface;
+use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+
+final readonly class SparseFieldsetParameterProvider implements ParameterProviderInterface
+{
+    public function provide(Parameter $parameter, array $parameters = [], array $context = []): ?Operation
+    {
+        if (!($operation = $context['operation'] ?? null)) {
+            return null;
+        }
+
+        $allowedProperties = $parameter->getExtraProperties()['_properties'] ?? [];
+        $value = $parameter->getValue();
+        $normalizationContext = $operation->getNormalizationContext();
+
+        if (!\is_array($value)) {
+            return null;
+        }
+
+        $properties = [];
+        $shortName = strtolower($operation->getShortName());
+        foreach ($value as $resource => $fields) {
+            if (strtolower($resource) === $shortName) {
+                $p = &$properties;
+            } else {
+                $properties[$resource] = [];
+                $p = &$properties[$resource];
+            }
+
+            foreach (explode(',', $fields) as $f) {
+                if (\array_key_exists($f, $allowedProperties)) {
+                    $p[] = $f;
+                }
+            }
+        }
+
+        if (isset($normalizationContext[AbstractNormalizer::ATTRIBUTES])) {
+            $properties = array_merge_recursive((array) $normalizationContext[AbstractNormalizer::ATTRIBUTES], $properties);
+        }
+
+        $normalizationContext[AbstractNormalizer::ATTRIBUTES] = $properties;
+
+        return $operation->withNormalizationContext($normalizationContext);
+    }
+}

src/Laravel/ApiPlatformProvider.php

@@ -57,6 +57,8 @@
 use ApiPlatform\Hydra\Serializer\HydraPrefixNameConverter;
 use ApiPlatform\Hydra\Serializer\PartialCollectionViewNormalizer as HydraPartialCollectionViewNormalizer;
 use ApiPlatform\Hydra\State\HydraLinkProcessor;
+use ApiPlatform\JsonApi\Filter\SparseFieldset;
+use ApiPlatform\JsonApi\Filter\SparseFieldsetParameterProvider;
 use ApiPlatform\JsonApi\JsonSchema\SchemaFactory as JsonApiSchemaFactory;
 use ApiPlatform\JsonApi\Serializer\CollectionNormalizer as JsonApiCollectionNormalizer;
 use ApiPlatform\JsonApi\Serializer\EntrypointNormalizer as JsonApiEntrypointNormalizer;
@@ -84,6 +86,8 @@
 use ApiPlatform\Laravel\Eloquent\Filter\DateFilter;
 use ApiPlatform\Laravel\Eloquent\Filter\EqualsFilter;
 use ApiPlatform\Laravel\Eloquent\Filter\FilterInterface as EloquentFilterInterface;
+use ApiPlatform\Laravel\Eloquent\Filter\JsonApi\SortFilter;
+use ApiPlatform\Laravel\Eloquent\Filter\JsonApi\SortFilterParameterProvider;
 use ApiPlatform\Laravel\Eloquent\Filter\OrderFilter;
 use ApiPlatform\Laravel\Eloquent\Filter\PartialSearchFilter;
 use ApiPlatform\Laravel\Eloquent\Filter\RangeFilter;
@@ -106,6 +110,7 @@
 use ApiPlatform\Laravel\Exception\ErrorHandler;
 use ApiPlatform\Laravel\GraphQl\Controller\EntrypointController as GraphQlEntrypointController;
 use ApiPlatform\Laravel\GraphQl\Controller\GraphiQlController;
+use ApiPlatform\Laravel\JsonApi\State\JsonApiProvider;
 use ApiPlatform\Laravel\Metadata\CachePropertyMetadataFactory;
 use ApiPlatform\Laravel\Metadata\CachePropertyNameCollectionMetadataFactory;
 use ApiPlatform\Laravel\Metadata\CacheResourceCollectionMetadataFactory;
@@ -421,7 +426,15 @@ public function register(): void
 
         $this->app->bind(OperationMetadataFactoryInterface::class, OperationMetadataFactory::class);
 
-        $this->app->tag([EqualsFilter::class, PartialSearchFilter::class, DateFilter::class, OrderFilter::class, RangeFilter::class], EloquentFilterInterface::class);
+        $this->app->tag([
+            EqualsFilter::class,
+            PartialSearchFilter::class,
+            DateFilter::class,
+            OrderFilter::class,
+            RangeFilter::class,
+            SortFilter::class,
+            SparseFieldset::class,
+        ], EloquentFilterInterface::class);
 
         $this->app->bind(FilterQueryExtension::class, function (Application $app) {
             $tagged = iterator_to_array($app->tagged(EloquentFilterInterface::class));
@@ -468,6 +481,12 @@ public function register(): void
             return new DeserializeProvider($app->make(ValidateProvider::class), $app->make(SerializerInterface::class), $app->make(SerializerContextBuilderInterface::class));
         });
 
+        if (class_exists(JsonApiProvider::class)) {
+            $this->app->extend(DeserializeProvider::class, function (ProviderInterface $inner, Application $app) {
+                return new JsonApiProvider($inner);
+            });
+        }
+
         $this->app->tag([PropertyFilter::class], SerializerFilterInterface::class);
 
         $this->app->singleton(SerializerFilterParameterProvider::class, function (Application $app) {
@@ -477,7 +496,10 @@ public function register(): void
         });
         $this->app->alias(SerializerFilterParameterProvider::class, 'api_platform.serializer.filter_parameter_provider');
 
-        $this->app->tag([SerializerFilterParameterProvider::class], ParameterProviderInterface::class);
+        $this->app->singleton(SortFilterParameterProvider::class, function (Application $app) {
+            return new SortFilterParameterProvider();
+        });
+        $this->app->tag([SerializerFilterParameterProvider::class, SortFilterParameterProvider::class, SparseFieldsetParameterProvider::class], ParameterProviderInterface::class);
 
         $this->app->singleton('filters', function (Application $app) {
             return new ServiceLocator(array_merge(

src/Laravel/Eloquent/Filter/JsonApi/SortFilter.php

@@ -0,0 +1,62 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Laravel\Eloquent\Filter\JsonApi;
+
+use ApiPlatform\Laravel\Eloquent\Filter\FilterInterface;
+use ApiPlatform\Metadata\JsonSchemaFilterInterface;
+use ApiPlatform\Metadata\Parameter;
+use ApiPlatform\Metadata\ParameterProviderFilterInterface;
+use ApiPlatform\Metadata\PropertiesAwareInterface;
+use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Database\Eloquent\Model;
+
+final class SortFilter implements FilterInterface, JsonSchemaFilterInterface, ParameterProviderFilterInterface, PropertiesAwareInterface
+{
+    public const ASC = 'asc';
+    public const DESC = 'desc';
+
+    /**
+     * @param Builder<Model>       $builder
+     * @param array<string, mixed> $context
+     */
+    public function apply(Builder $builder, mixed $values, Parameter $parameter, array $context = []): Builder
+    {
+        if (!\is_array($values)) {
+            return $builder;
+        }
+
+        foreach ($values as $order => $dir) {
+            if (self::ASC !== $dir && self::DESC !== $dir) {
+                continue;
+            }
+
+            $builder->orderBy($order, $dir);
+        }
+
+        return $builder;
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function getSchema(Parameter $parameter): array
+    {
+        return ['type' => 'string'];
+    }
+
+    public static function getParameterProvider(): string
+    {
+        return SortFilterParameterProvider::class;
+    }
+}

src/Laravel/Eloquent/Filter/JsonApi/SortFilterParameterProvider.php

@@ -0,0 +1,55 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Laravel\Eloquent\Filter\JsonApi;
+
+use ApiPlatform\Metadata\Operation;
+use ApiPlatform\Metadata\Parameter;
+use ApiPlatform\State\ParameterProviderInterface;
+
+final readonly class SortFilterParameterProvider implements ParameterProviderInterface
+{
+    public function provide(Parameter $parameter, array $parameters = [], array $context = []): ?Operation
+    {
+        if (!($operation = $context['operation'] ?? null)) {
+            return null;
+        }
+
+        $parameters = $operation->getParameters();
+        $properties = $parameter->getExtraProperties()['_properties'] ?? [];
+        $value = $parameter->getValue();
+        if (!\is_string($value)) {
+            return $operation;
+        }
+
+        $values = explode(',', $value);
+        $orderBy = [];
+        foreach ($values as $v) {
+            $dir = SortFilter::ASC;
+            if (str_starts_with($v, '-')) {
+                $dir = SortFilter::DESC;
+                $v = substr($v, 1);
+            }
+
+            if (\array_key_exists($v, $properties)) {
+                $orderBy[$properties[$v]] = $dir;
+            }
+        }
+
+        $parameters->add($parameter->getKey(), $parameter->withExtraProperties(
+            ['_api_values' => $orderBy] + $parameter->getExtraProperties()
+        ));
+
+        return $operation->withParameters($parameters);
+    }
+}

src/Laravel/Eloquent/Metadata/Factory/Property/EloquentPropertyNameCollectionMetadataFactory.php

@@ -73,7 +73,7 @@ public function create(string $resourceClass, array $options = []): PropertyName
         }
 
         return new PropertyNameCollection(
-            array_keys($properties) // @phpstan-ignore-line
+            array_keys($properties)
         );
     }
 }

src/Laravel/JsonApi/State/JsonApiProvider.php

@@ -0,0 +1,66 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Laravel\JsonApi\State;
+
+use ApiPlatform\Metadata\Operation;
+use ApiPlatform\State\ProviderInterface;
+
+/**
+ * This is a copy of ApiPlatform\JsonApi\State\JsonApiProvider without the support of sort,filter and fields as these should be implemented using QueryParameters and specific Filters.
+ * At some point we want to merge both classes but for now we don't have the SortFilter inside Symfony.
+ *
+ * @internal
+ */
+final class JsonApiProvider implements ProviderInterface
+{
+    public function __construct(private readonly ProviderInterface $decorated)
+    {
+    }
+
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
+    {
+        $request = $context['request'] ?? null;
+
+        if (!$request || 'jsonapi' !== $request->getRequestFormat()) {
+            return $this->decorated->provide($operation, $uriVariables, $context);
+        }
+
+        $filters = $request->attributes->get('_api_filters', []);
+        $queryParameters = $request->query->all();
+
+        $pageParameter = $queryParameters['page'] ?? null;
+        if (
+            \is_array($pageParameter)
+        ) {
+            $filters = array_merge($pageParameter, $filters);
+        }
+
+        if (isset($pageParameter['offset'])) {
+            $filters['page'] = $pageParameter['offset'];
+            unset($filters['offset']);
+        }
+
+        $includeParameter = $queryParameters['include'] ?? null;
+
+        if ($includeParameter) {
+            $request->attributes->set('_api_included', explode(',', $includeParameter));
+        }
+
+        if ($filters) {
+            $request->attributes->set('_api_filters', $filters);
+        }
+
+        return $this->decorated->provide($operation, $uriVariables, $context);
+    }
+}