varnish is not provided by the default distribution anymore #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Sep 17, 2023
| @@ -20,11 +20,7 @@ cache. This ensures that the content served will always be fresh, because the ca | |||
| most specific cases such as the invalidation of collections when a document is added or removed or for relationships and | |||
| inverse relations is built-in. | |||
|
|
|||
| Integration with Varnish and Doctrine ORM is shipped with the core library, and [Varnish](https://varnish-cache.org/) is | |||
There was a problem hiding this comment.
Maybe can we keep this part of the sentence "Integration with Varnish and Doctrine ORM is shipped with the Core library.", which is still true.
We may also mention that we now support Souin too.
There was a problem hiding this comment.
ah, indeed, i deleted a bit too much. i added that line back.
i don't know souin, maybe better somebody who knows about it adds some information.
|
@dunglas is the varnish side of the configuration documented somewhere? e.g. how to handle the tag invalidation requests? |
|
thanks @dbu ! I guess the only docs is at https://github.com/api-platform/core/pull/5273/files#diff-5d7f4ac044cc872666abe48c4b0bfd771f274fbf8117db065fc8029eebd82841 I need to add this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in api-platform/api-platform#2133 varnish is not provided in the default setup, therefore the documentation is confusing.
on a quick search i did not find any instructions on how to set up the varnish side to work with the invalidation requests. i guess it would be found in old branches of api-platform that still contained varnish. if there is documentation somewhere, i'd be happy to link to it because as is, these instructions are not very user friendly when having to figure out completely on your own how to configure the caching proxy.