Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laravel/index.md file #2036

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

noweh
Copy link
Contributor

@noweh noweh commented Oct 12, 2024

  • Added missing 'use' statements in the laravel/index.md for clarity
  • Fixed a typo in a Model usage
  • Corrected 'ProviderInterface::class' to 'provider' in ApiServiceProvider

Solves api-platform/core#6717

- Added missing 'use' statements in the laravel/index.md for clarity
- Fixed a typo in a Model usage
- Corrected 'ProviderInterface::class' to 'provider' in ApiServiceProvider
laravel/index.md Outdated Show resolved Hide resolved
Change 'provider' to ProviderInterface::class in laravel/index.md
laravel/index.md Outdated Show resolved Hide resolved
Fix some docs about DTO
@noweh
Copy link
Contributor Author

noweh commented Oct 14, 2024

This PR fix this issue : api-platform/core#6717

laravel/index.md Outdated Show resolved Hide resolved
Use the constructor property promotion syntax in ApiResource/Book
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @soyuka could you take a look please?

@vinceAmstoutz
Copy link
Contributor

Can you please rebase @noweh? I'll merge it after.

@soyuka soyuka merged commit 2fd0a82 into api-platform:4.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants