Document input/output resource attribute #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Nov 9, 2018
core/dto.md
Outdated
| use App\Dto\Output; | ||
|
|
||
| /** | ||
| * @ApiResource(attributes={ |
There was a problem hiding this comment.
You could use the shortcuts inputClass and outputClass directly
core/dto.md
Outdated
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ |
core/dto.md
Outdated
| use App\Dto\Input; | ||
| use App\Dto\Output; | ||
|
|
||
| class InputDataPersister implements DataPersisterInterface |
There was a problem hiding this comment.
Suggested change
| class InputDataPersister implements DataPersisterInterface | |
| final class InputDataPersister implements DataPersisterInterface |
|
Shouldn't we remove the previous sections in the same file (https://api-platform.com/docs/core/dto/#how-to-use-a-dto-for-writing). |
|
Yeah we should def remove the previous sections, but we need swagger support first :|. |
dunglas
approved these changes
Nov 14, 2018
antograssiot
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api-platform/core#2235 ping @silverbackdan