-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint and related dependencies #975
Conversation
This is amazing! Thanks so much. I hope the |
BTW it looks like there are still some leftovers - the Travis build fails rightfully, on linter.
|
7d5700c
to
69965e5
Compare
@honzajavorek I didn't quite get that far last week but I've made a separate PR for that change as it's independent of the eslint upgrade. See #979 |
69965e5
to
072fa26
Compare
Ouch, that's gonna take a while to unblock |
Yup. |
This removes some indirect dev dependencies.
* eslint@5.6.1 * eslint-plugin-import@2.14.0 * eslint-config-airbnb-base@13.1.0
072fa26
to
73f1501
Compare
@honzajavorek Rebased on master and updated everything to the newest version. I know that some of the licensing issues have been resolved but not all of them. Can you re-run the license check? |
@realityking I'm sorry, I had vacation, hence the delay. I'll re-check, but recently I did some re-checks because we resolved a lot of dependencies and I think ESlint is still problematic. We're currently hunting down a lot of this stuff, but dev dependencies have lower priority. |
🎉 This issue has been resolved in version 5.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🚀 Why this change?
eslint and related dependencies are out of date. This updates them to their newest version. Part of this PR was originally part of #969.
This probably can't be merged until there's been a new release of
eslint-config-airbnb-base
(see #969 for discussion)Other changes:
eslint-config-airbnb
toeslint-config-airbnb-base
. This project is not using the React related parts and this drops some indirect dev dependencies.eslint-config-airbnb-base
prefer-destructuring
. The rule is now part ofeslint-config-airbnb-base
but this didn't seem worth fixing. (Could always be done at a later time)Buffer
constructor, also a new error fromeslint-config-airbnb-base
📝 Related issues and Pull Requests
✅ What didn't I forget?
npm run lint