Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint and related dependencies #975

Closed
wants to merge 3 commits into from

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Feb 24, 2018

🚀 Why this change?

eslint and related dependencies are out of date. This updates them to their newest version. Part of this PR was originally part of #969.

This probably can't be merged until there's been a new release of eslint-config-airbnb-base (see #969 for discussion)

Other changes:

  • Switch from eslint-config-airbnb to eslint-config-airbnb-base. This project is not using the React related parts and this drops some indirect dev dependencies.
  • Fix new style issues due to the update to eslint-config-airbnb-base
  • Disable prefer-destructuring. The rule is now part of eslint-config-airbnb-base but this didn't seem worth fixing. (Could always be done at a later time)
  • Fix use of the Buffer constructor, also a new error from eslint-config-airbnb-base

📝 Related issues and Pull Requests

✅ What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@realityking realityking changed the title Update aslant and related dependencies Update eslint and related dependencies Feb 24, 2018
@honzajavorek
Copy link
Contributor

This is amazing! Thanks so much. I hope the eslint-config-airbnb-base gets released soon so this PR won't get outdated or won't get merge conflicts.

@honzajavorek
Copy link
Contributor

BTW it looks like there are still some leftovers - the Travis build fails rightfully, on linter.

cli-test.js
336:179 error new Buffer() is deprecated. Use Buffer.from(), Buffer.alloc(), or Buffer.allocUnsafe() instead no-buffer-constructor

@realityking
Copy link
Contributor Author

@honzajavorek I didn't quite get that far last week but I've made a separate PR for that change as it's independent of the eslint upgrade. See #979

@honzajavorek
Copy link
Contributor

Unfortunately blocked by #1047, #1046, #1045.

@realityking
Copy link
Contributor Author

Ouch, that's gonna take a while to unblock

@honzajavorek
Copy link
Contributor

Yup.

This removes some indirect dev dependencies.
* eslint@5.6.1
* eslint-plugin-import@2.14.0
* eslint-config-airbnb-base@13.1.0
@realityking
Copy link
Contributor Author

@honzajavorek Rebased on master and updated everything to the newest version. I know that some of the licensing issues have been resolved but not all of them. Can you re-run the license check?

@honzajavorek
Copy link
Contributor

@realityking I'm sorry, I had vacation, hence the delay. I'll re-check, but recently I did some re-checks because we resolved a lot of dependencies and I think ESlint is still problematic. We're currently hunting down a lot of this stuff, but dev dependencies have lower priority.

@ApiaryBot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants