This repository has been archived by the owner on Jul 2, 2019. It is now read-only.
Disallow source document to be object #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel like allowing the source document to be a JavaScript object was a developer convince, but it is an anti-pattern as there will be no source maps for these types of source documents. This will prevent any accidental parsing of an object to the parser causing missing source maps. BREAKING CHANGE
kylef
force-pushed
the
kylef/js-object
branch
from
de3704f
to
fa62ed6
Compare
pksunkara
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parser allows you to feed in JavaScript objects instead of a JSON or YAML document. I feel like allowing the source document to be a JavaScript object was a developer convince, but it is an anti-pattern as there will be no source maps for these types of source documents.
This will prevent any accidental parsing of an object to the parser causing missing source maps.
BREAKING CHANGE