Support nodejs 3.0 and 4.0

[danielgtaylor]

I'm seeing build failures on CI hosts using the recently released iojs 3.0.0:

https://travis-ci.org/danielgtaylor/aglio/jobs/75231420

The issue seems to be related to nan. This other project is moving to nan 2.x to fix a similar issue:

Automattic/node-canvas#606

[Freundschaft]

yes also it doesnt work right now with nodejs 4.0 as far as i can see

[pksunkara]

Ah, we need to fix this using nan.

[mrmurphy]

What's the preferred way for you to know when issues are important to other people? I don't want to spam with +1 here, but I'm interested in throwing in my vote for attention to this issue. I'd love to move to Node 4.0 when possible. Thanks so much for all your work!

[pksunkara]

@splodingsocks Using +1 is perfectly okay with us. 😄

We are working on an important release first and would prefer to not do this until that. Any contributions are welcome though. We have to update the nan package version and fix any issues (most probably none) that rise up.

[mrmurphy]

Okay, great! I wish I were able to dive in right now and figure out how to do this, never having compiled native extensions before. If I'm able to, I'll post back here. If not, I'll just be patient :)

Thanks again!

[zakhenry]

+1 This is causing issues with travis ci failing to compile (tried base travis config, 0.12 & 4.0.0)

[ChALkeR]

Adding to the list: nodejs/node#2798.
You have to update nan to v2.

[tobiashm]

I've made a PR #90 with an upgrade to Nan 2.0
This was done mostly using a script. It seems to be working fine on my machine with Node 4.0 and 4.1, but it currently fails on the CI builds, so I'm a bit lost on what's wrong.
If anyone has more knowledge about the code could take a look, that would be great, because I actually don't know what I'm doing here :-) I'm not a C/C++ developer.

[ChALkeR]

@tobiashm Travis builds are failing because they use gcc 4.6, while the minimum supported gcc version is 4.8. Travis config has to be changed.

[zdne]

Travis builds are failing because they use gcc 4.6, while the minimum supported gcc version is 4.8. Travis config has to be changed.

So upgrading to support Node.js 3+ implies we discontinue supporting systems with GCC 4.6? /cc @klokane

[trodrigues]

Not a big deal but also ran into this using https://www.npmjs.com/package/aglio

[ChALkeR]

@zdne

So upgrading to support Node.js 3+ implies we discontinue supporting systems with GCC 4.6?

No, it doesn't. Afaik, your package will work with old gcc and old node, with new gcc and old node, with new gcc and new node, but not with old gcc and new node. Without this patch, your package doesn't work with new node at all.

[klokane]

I'm going to decide about supported versions of compilers in next week, make some testing and we will see

[ChALkeR]

Not quite sure what are you going to decide on. Node.js 4.0 won't compile with GCC 4.6.
In order to compile with Node.js 4.0, one should use a more recent gcc version.
See https://github.com/nodejs/node#unix--macintosh.

[klokane]

Thanks for link.

We are thinking about drop support of older version compilers and allow some subset of C++ 11 features in drafter/snowcrash codebase.

[igrayson]

Looking forward to using 4.0, so +1

[zanuka]

👍

[fesor]

👍

[dkcwd]

👍

[RapsIn4]

👍

[tbostelmann]

👍

[tobiashm]

There's a lot of support for this issue. If anyone could take a look at #90 and help sorting out the last issues, we might be able to close it 😸

[artlogic]

👍

[ghost]

👍

[zachgersh]

👍
Just hit this today with v4.1.1.

[natdm]

Hitting it with rpi-gpio. 4.1.1.

[tobiashm]

Since #90 has been merged, this issue could now be closed.
So now we are just awaiting a new release version ;-)

[pksunkara]

The master branch now supports nodejs 3.0 and 4.0. We still need to fix a few bugs in apiaryio/drafter and release protagonist.

[rvlander]

Any idea of when it will be released?

[pksunkara]

@rvlander We are working on this. There are a few changes which need to be made to Drafter before this can be done.

[kadishmal]

👍 Can't upgrade aglio due to this issue.

[ye]

👍 I guess this issue is the root cause of this one danielgtaylor/aglio#183

[kylef]

Thanks for your patience everyone. Protagonist 1.1.0 now supports Node 3 and Node 4.

NOTE: Any tooling such as Aglio will need to be moved to use Protagonist 1.1.0.

[zanuka]

👍

[ScotterC]

@ChALkeR thanks for this comment #81 (comment). I had GCC 4.6 and Node 4 and it wasn't working. Downgrading to Node 0.12 fixes the protagonist compilation if you can't upgrade GCC

[ChALkeR]

@ScotterC I don't recommend downgrading to 0.12.