fix: three small corrections in markup and code #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
added
the
t-academy
honzajavorek
commented
May 21, 2024
| @@ -119,7 +119,7 @@ const msg = await page.evaluate(() => returnMessage()); | |||
|
|
|||
| console.log(msg); | |||
|
|
|||
| await page.waitForTimeout(20000); | |||
| await page.waitForTimeout(10000); | |||
There was a problem hiding this comment.
I'll ping @metalwarrior665 here because I just want to be sure I'm correcting a typo here. This code example has different timeout for Puppeteer and Playwright. I don't think there is a particular reason to it, so I assume it's just a typo. But maybe you'll remember if it is or is not intentional.
39 tasks
honzajavorek
force-pushed
the
honzajavorek/fix-code-markup
branch
from
c63be9c
to
5173261
Compare
|
@metalwarrior665 @TC-MO Is this okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.