Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies, fix build errors #253

Merged
merged 4 commits into from
Sep 13, 2021
Merged

chore: update dependencies, fix build errors #253

merged 4 commits into from
Sep 13, 2021

Conversation

vladfrangu
Copy link
Member

Supersedes #248 and #251

@vladfrangu vladfrangu added the dependencies Pull requests that update a dependency file. label Sep 8, 2021
@vladfrangu
Copy link
Member Author

CI is failing due to a v8 bug nodejs/node#40030 🥶

B4nan
B4nan approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, let's wait for a few days and hope they will fix it soon :]

@vladfrangu
Copy link
Member Author

Node.js released 16.9.1 to patch the v8 regression, and CI passes now! 🎉

@B4nan B4nan merged commit 1b48492 into master Sep 13, 2021
@B4nan B4nan deleted the chore/depenency-updates branch September 13, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladfrangu @B4nan