Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing create*Router helper for AdaptivePlaywrightCrawler #2407

Closed
janbuchar opened this issue Apr 8, 2024 · 0 comments · Fixed by #2415
Closed

Missing create*Router helper for AdaptivePlaywrightCrawler #2407

janbuchar opened this issue Apr 8, 2024 · 0 comments · Fixed by #2415
Assignees
@janbuchar
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

There are convenience functions for all remaining crawler types, and this makes it difficult to write adaptive scrapers.
@janbuchar janbuchar added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 8, 2024
@janbuchar janbuchar mentioned this issue Apr 10, 2024
Merged
B4nan pushed a commit that referenced this issue Apr 10, 2024
@janbuchar
feat: createAdaptivePlaywrightRouter utility (#2415)
cee4778 
- closes #2407
- the function itself makes it easier to use a Router for
structured adaptive crawling
- in this PR, we also export the `AdaptivePlaywrightCrawlerContext` type
and relax the type parameter constraint on `Router` to
`RestrictedCrawlingContext`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbuchar janbuchar

Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: createAdaptivePlaywrightRouter utility apify/crawlee
1 participant
@janbuchar