-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring crawler statistics #2213
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6b9cd5a
feat(core): allow persistence disabling in Statistics
foxt451 99c1880
feat(core): allow persistence disabling for SessionPool
foxt451 9f4e015
feat(basic-crawler): customizable options for created Statistics inst…
foxt451 0adb7d6
Update packages/core/src/crawlers/statistics.ts
foxt451 54a752f
fix: remove *force functions in favor of parameters
foxt451 1ca2536
Update packages/core/src/crawlers/statistics.ts
foxt451 8f3a10e
Update packages/core/src/crawlers/statistics.ts
foxt451 8da3b0c
Update packages/core/src/session_pool/session_pool.ts
foxt451 5f8c3b6
Update packages/core/src/session_pool/session_pool.ts
foxt451 a4eca60
feat: add PersistenceOptionsOverrides
foxt451 a611e07
chore: fix condition style
foxt451 161c185
fix: some PR remarks
foxt451 fc0b44d
fix: enable persistence by default
foxt451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like to keep one blank line after control statements like
if/for/while/etc
, this applies to other places in the PR too (e.g. thepersistState
method), take it as a rule of thumb