Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid CONNECT responses #151

Merged
merged 6 commits into from
Aug 24, 2021
Merged

fix: invalid CONNECT responses #151

merged 6 commits into from
Aug 24, 2021

Conversation

szmarczak
Copy link
Contributor

No description provided.

Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jancurn
Copy link
Member

jancurn commented Aug 23, 2021

Any chance to cover this in unit tests too?

@szmarczak
Copy link
Contributor Author

Will do, just wanted to test this in apify-proxy before.

@szmarczak szmarczak marked this pull request as ready for review August 24, 2021 08:38
@szmarczak szmarczak merged commit 0043ac9 into master Aug 24, 2021
@szmarczak szmarczak deleted the fix-invalid-response branch August 24, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants