Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support localAddress #163

Merged
merged 3 commits into from
Oct 11, 2021
Merged

feat: support localAddress #163

merged 3 commits into from
Oct 11, 2021

Conversation

szmarczak
Copy link
Contributor

No description provided.

@szmarczak szmarczak requested review from B4nan and mnmkng October 10, 2021 22:21
@szmarczak szmarczak mentioned this pull request Oct 10, 2021
Merged
@szmarczak szmarczak marked this pull request as ready for review October 10, 2021 22:22
@szmarczak szmarczak marked this pull request as draft October 11, 2021 08:03
@szmarczak szmarczak marked this pull request as ready for review October 11, 2021 08:10
jancurn
jancurn approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just FYI, today I will try to review the large release.

@szmarczak szmarczak merged commit eca4fbd into next Oct 11, 2021
@szmarczak szmarczak deleted the next-localaddress branch October 11, 2021 08:13
@szmarczak szmarczak mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancurn jancurn jancurn approved these changes

@B4nan B4nan Awaiting requested review from B4nan

@mnmkng mnmkng Awaiting requested review from mnmkng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szmarczak @jancurn