feat: closeConnection by id
#176
Conversation
| /** | ||
| * Forcibly close a specific pending proxy connection. | ||
| */ | ||
| closeConnection(connectionId: unknown): void { |
There was a problem hiding this comment.
Why would you need this?
There was a problem hiding this comment.
because there are no timeouts and if the remote server keeps connection open/hangs up then it will keep the connection open forever, I had the same issue. I resolved it similarly as in this PR but checking if remote upstream server hasn't sent any bytes yet so its considered as a timeout
There was a problem hiding this comment.
Sorry for late reply. I think you could override
Line 203 in a6d51fb
super.onConnection(socket)).
Alternatively, you could access proxyChainServer.server to get the underlying native http server.
There was a problem hiding this comment.
We mainly need that to be able to terminate specific connections, if they overuse their data plans.
There was a problem hiding this comment.
Makes sense. Thanks for explanation :)
| const socket = this.connections.get(connectionId); | ||
| if (!socket) return; | ||
|
|
||
| socket.destroy(); |
There was a problem hiding this comment.
Destroy actually doesn't destroy the socket (however it tries to close it). See nodejs/node#27428
szmarczak
changed the title
closeConnection by id
No description provided.