-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer App Analytics page for Hybrid Org #105 #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to hybrid organization for analytics funtions
Add support to hybrid organization for getMetrics & cs fix
Correction in declaration type
phdhiren
requested review from
cnovak,
raakesh-blokhra,
shishir-intelli and
divya-intelli
February 1, 2021 13:28
fix phpdoc_tag_type
query_params to be initialize
mxr576
reviewed
Feb 9, 2021
mxr576
reviewed
Feb 9, 2021
Till finalized for PHP 8 compatibility restricting polyfill-mbstring library to beyond 1.20.0
raakesh-blokhra
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
The pull request will fix apigee/apigee-edge-drupal#481 |
This was referenced Mar 18, 2021
raakesh-blokhra
added a commit
that referenced
this pull request
Apr 19, 2021
* restrict polyfill-mbstring to 1.20.0 / Fix travis-ci (#121) Added support for PHP 7.3 + Fix .travis.yml + restrict polyfill-mbstring to 1.20.0 * Developer App Analytics page for Hybrid Org #105 (#123) Resolved Error on Developer App Analytics page for Hybrid Org #105 * Closes-#108 - After creating app without description throwing php not… (#125) * Closes-#108 - After creating app without description throwing php notice in hybrid - fixed * App Analytics page - Fix PHP error on empty data (#133) Fix PHP error in case of empty data for Analytics page Co-authored-by: phdhiren <71828912+phdhiren@users.noreply.github.com> Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com>
raakesh-blokhra
added a commit
that referenced
this pull request
Apr 19, 2021
* restrict polyfill-mbstring to 1.20.0 / Fix travis-ci in feature-ngmint (#132) * restrict polyfill-mbstring to 1.20.0 * Enabled PHP 7.1, 7.2, 7.3 * FIx travis-ci for feature-ngmint * Code for Purchase,Cancel,Listing of Purchased Products (#131) * Code for Purchase,Cancel,Listing of Purchased Products * phpcs fix * phpcsfixer * code cleanup phpcs * phpcsfix * phpcs fixes * phpcs fix * phpcsfixes Co-authored-by: Hirenkumar Parmar <hirenkumar@google.com> Co-authored-by: phdhiren <71828912+phdhiren@users.noreply.github.com> * Initial Commit for NGMint (ApigeeX 5G) (#130) * Initial Commit for NGMint * Feature ngmint - updated by pulling code from 2.x (#136) * restrict polyfill-mbstring to 1.20.0 / Fix travis-ci (#121) Added support for PHP 7.3 + Fix .travis.yml + restrict polyfill-mbstring to 1.20.0 * Developer App Analytics page for Hybrid Org #105 (#123) Resolved Error on Developer App Analytics page for Hybrid Org #105 * Closes-#108 - After creating app without description throwing php not… (#125) * Closes-#108 - After creating app without description throwing php notice in hybrid - fixed * App Analytics page - Fix PHP error on empty data (#133) Fix PHP error in case of empty data for Analytics page Co-authored-by: phdhiren <71828912+phdhiren@users.noreply.github.com> Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com> Co-authored-by: phdhiren <71828912+phdhiren@users.noreply.github.com> Co-authored-by: divya-intelli <75604843+divya-intelli@users.noreply.github.com> Co-authored-by: Hirenkumar Parmar <hirenkumar@google.com> Co-authored-by: Shishir <75600200+shishir-intelli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytics page for Hybrid org, there was change in API end points for hybrid orgs
Reference issues:
#105
apigee/apigee-edge-drupal#552
apigee/apigee-edge-drupal#481