DRUP-801 Add forked AddPathPlugin and removed required patch #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md contained a reference to an outdated required patch (103) for php-http/client-common:1.x. The composer.json contained the correct reference (113). Although, that patch also became outdated because it did not contain a bulletproof fix for the problem. The issue has been properly fixed in the 2.x branch. This is the reason why we forked the fixed version from the 2.x branch and with that also removed all the overhead caused by conditional patching the php-http/client-common dependency. php-http/client-common#171
Codecov Report
@@ Coverage Diff @@
## 2.x #54 +/- ##
============================================
- Coverage 91.34% 91.26% -0.09%
- Complexity 1717 1722 +5
============================================
Files 266 267 +1
Lines 3338 3353 +15
============================================
+ Hits 3049 3060 +11
- Misses 289 293 +4
Continue to review full report at Codecov.
|
|
@balazswmann FYI, this PR addresses the documentation issue that you found. |
mxr576
changed the title
mxr576
added a commit
to mxr576/apigee-edge-drupal
that referenced
this pull request
May 21, 2019
Jaesin
pushed a commit
to mxr576/apigee-edge-drupal
that referenced
this pull request
May 23, 2019
mxr576
added a commit
to mxr576/apigee-edge-drupal
that referenced
this pull request
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md contained a reference to an outdated required patch (103)
for php-http/client-common:1.x. The composer.json contained the correct
reference (113). Although, that patch also became outdated because it
did not contain a bulletproof fix for the problem.
The issue has been properly fixed in the 2.x branch. This is the reason
why we forked the fixed version from the 2.x branch and with that
also removed all the overhead caused by conditional patching the
php-http/client-common dependency.
php-http/client-common#171
TODO: