Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant jars and conditions when Hybrid 1.5 support drops #246

Closed
rockspore opened this issue May 5, 2022 · 2 comments · Fixed by #248
Closed

Remove redundant jars and conditions when Hybrid 1.5 support drops #246

rockspore opened this issue May 5, 2022 · 2 comments · Fixed by #248
Assignees

Comments

@rockspore
Copy link
Contributor

The current version checking has a flaw in that it can't work well when the minor version reaches two digits. This should be still far away from now but we should be able to stop relying on the version check to select a particular products callout jar once Hybrid 1.5 is not supported by Apigee any more.

@rockspore
Copy link
Contributor Author

1.5 and even 1.6 are not supported Hybrid version any more (evidence: https://cloud.google.com/apigee/docs/hybrid/supported-platforms). I think it's time to get rid of this time bomb.
@theganyo @emschwar

@rockspore
Copy link
Contributor Author

<Step>
<Name>Get-Runtime-Version</Name>
</Step>
<Step>
<Name>Legacy-Products-Callout</Name>
<Condition>(lookupcache.Lookup-Products.cachehit = false) and (runtime_version LesserThan "1.5.0")</Condition>
</Step>
<Step>
<Name>Products-Callout</Name>
<Condition>(lookupcache.Lookup-Products.cachehit = false) and (runtime_version GreaterThanOrEquals "1.5.0"</Condition>
</Step>
is the condition that needs to be cleaned up.

https://github.com/apigee/apigee-remote-service-cli/blob/main/cmd/provision/proxies/remote-service-gcp/apiproxy/resources/py/get-runtime-version.py will eventually stop working properly once the minor version reaches double-digit. But this is not harmful as long as it's not used in critical places like above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant