Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always include k8s sa during provisioning #103

Merged
merged 2 commits into from
Nov 16, 2020
Merged

always include k8s sa during provisioning #103

merged 2 commits into from
Nov 16, 2020

Conversation

rockspore
Copy link
Contributor

k8s sa specification will be not included when sample configurations are generated for legacy saas or opdk.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #103 (b145b1b) into master (11511b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.02%     
==========================================
  Files          16       16              
  Lines        1823     1822       -1     
==========================================
- Hits         1429     1428       -1     
  Misses        210      210              
  Partials      184      184              
Impacted Files Coverage Δ
cmd/provision/config.go 81.39% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11511b9...b145b1b. Read the comment docs.

@rockspore rockspore changed the title made k8s sa conditional always include k8s sa during provisioning Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s service account resource not needed for other platforms
2 participants